Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): for-direction rule add check for condition in reverse o… #1418

Merged
merged 1 commit into from Nov 18, 2023
Merged

feat(linter): for-direction rule add check for condition in reverse o… #1418

merged 1 commit into from Nov 18, 2023

Conversation

ild0tt0re
Copy link
Contributor

Align eslint for-direction rule with the new default behaviour eslint/eslint#17755

@github-actions github-actions bot added the A-linter Area - Linter label Nov 18, 2023
@ild0tt0re ild0tt0re force-pushed the feat/for-direction-rule-missing-use-cases branch from a1023b4 to 092ddf6 Compare November 18, 2023 23:23
@ild0tt0re ild0tt0re force-pushed the feat/for-direction-rule-missing-use-cases branch from 092ddf6 to 4ee7c61 Compare November 18, 2023 23:28
camc314
camc314 approved these changes Nov 18, 2023
View reviewed changes
Copy link
Collaborator

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@camc314 camc314 merged commit b72f83b into oxc-project:main Nov 18, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camc314 camc314 camc314 approved these changes

Assignees
No one assigned
Labels
A-linter Area - Linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ild0tt0re @camc314