Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): eslint-plugin-unicorn prefer-set-size (correctness) #1508

Merged
merged 1 commit into from
Nov 23, 2023
Merged

feat(linter): eslint-plugin-unicorn prefer-set-size (correctness) #1508

merged 1 commit into from
Nov 23, 2023

Conversation

camc314
Copy link
Collaborator

@camc314 camc314 commented Nov 22, 2023

No description provided.

@camc314 camc314 mentioned this pull request Nov 22, 2023
Merged
@camc314 Graphite App
Copy link
Collaborator Author

camc314 commented Nov 22, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions bot added the A-linter Area - Linter label Nov 22, 2023
@Boshen Boshen changed the title feat(linter) eslint plugin unicorn prefer set size feat(linter): eslint-plugin-unicorn prefer-set-size Nov 23, 2023
@Boshen Boshen changed the title feat(linter): eslint-plugin-unicorn prefer-set-size feat(linter): eslint-plugin-unicorn prefer-set-size (correctness) Nov 23, 2023
Boshen
Boshen reviewed Nov 23, 2023
View reviewed changes
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice rule for correctness!

@Boshen Graphite App
Copy link
Member

Boshen commented Nov 23, 2023 •
edited

Merge activity

  • Nov 22, 9:59 PM: @Boshen started a stack merge that includes this pull request via Graphite.
  • Nov 22, 9:59 PM: Graphite rebased this pull request as part of a merge.
  • Nov 22, 10:03 PM: @Boshen merged this pull request with Graphite.

Base automatically changed from c/11-22-feat_linter_eslint_plugin_unicorn_prefer_native_coercion_functions to main November 23, 2023 02:59
@Boshen Boshen force-pushed the c/11-22-feat_linter_eslint_plugin_unicorn_prefer_set_size branch from 0730056 to 0ceacc0 Compare November 23, 2023 02:59
@Boshen Boshen merged commit 7930f90 into main Nov 23, 2023
15 checks passed
@Boshen Boshen deleted the c/11-22-feat_linter_eslint_plugin_unicorn_prefer_set_size branch November 23, 2023 03:03
@camc314 camc314 mentioned this pull request Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen left review comments

Assignees
No one assigned
Labels
A-linter Area - Linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@camc314 @Boshen