Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): eslint-plugin-jsx-a11y no-autofocus #1641

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

msdlisper
Copy link
Contributor

impl linter for #1141

@github-actions github-actions bot added the A-linter Area - Linter label Dec 7, 2023
Copy link

codspeed-hq bot commented Dec 7, 2023

CodSpeed Performance Report

Merging #1641 will degrade performances by 5.46%

Comparing msdlisper:no_autofocus (38b7433) with main (6e5aad2)

Summary

❌ 1 (👁 1) regressions
✅ 19 untouched benchmarks

Benchmarks breakdown

Benchmark main msdlisper:no_autofocus Change
👁 semantic[vue.js] 76.5 ms 80.9 ms -5.46%

@msdlisper
Copy link
Contributor Author

Why does my linter affect the Vue.js semantic analysis? 🤣

semantic[vue.js] Regression

@camc314 camc314 changed the title feat(linter): impl no-autofocuse lint for jsx_a11y feat(linter): eslint-plugin-jsx-a11y no-autofocuse Dec 7, 2023
@camc314 camc314 changed the title feat(linter): eslint-plugin-jsx-a11y no-autofocuse feat(linter): eslint-plugin-jsx-a11y no-autofocus Dec 7, 2023
@camc314
Copy link
Collaborator

camc314 commented Dec 7, 2023

Why does my linter affect the Vue.js semantic analysis? 🤣

semantic[vue.js] Regression

i think it's a buggy test case, there's often 5% regression/improvement on PRs

@Boshen Boshen merged commit d88f4f4 into oxc-project:main Dec 8, 2023
16 checks passed
@msdlisper msdlisper deleted the no_autofocus branch December 17, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants