Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): eslint-plugin-jsx-a11y role-has-required-aria-props rule #1881

Merged
merged 8 commits into from
Jan 9, 2024

Conversation

@github-actions github-actions bot added the A-linter Area - Linter label Jan 3, 2024
@yossydev yossydev marked this pull request as ready for review January 3, 2024 07:27
Copy link

codspeed-hq bot commented Jan 3, 2024

CodSpeed Performance Report

Merging #1881 will degrade performances by 6.49%

Comparing yossydev:role-has-required-aria-props (a42ef7d) with main (8a7efc2)

Summary

❌ 2 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main yossydev:role-has-required-aria-props Change
semantic[pdf.mjs] 113.2 ms 121 ms -6.49%
linter[pdf.mjs] 1.7 s 1.8 s -5.15%

Copy link
Collaborator

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last comment then this is good to go!

@yossydev yossydev requested a review from camc314 January 8, 2024 05:41
@yossydev yossydev force-pushed the role-has-required-aria-props branch from 7a2f75c to 16111e0 Compare January 8, 2024 05:46
Copy link
Collaborator

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@camc314 camc314 enabled auto-merge (squash) January 8, 2024 08:55
@camc314 camc314 force-pushed the role-has-required-aria-props branch from 16111e0 to a4b00a3 Compare January 8, 2024 08:55
auto-merge was automatically disabled January 9, 2024 03:08

Base branch was modified

@yossydev yossydev force-pushed the role-has-required-aria-props branch from 9d9a43c to a42ef7d Compare January 9, 2024 14:53
@yossydev yossydev requested a review from camc314 January 9, 2024 15:06
@yossydev
Copy link
Contributor Author

yossydev commented Jan 9, 2024

@camc314
I'm sorry after you approve! The CodSpeed Performance Report is dropping, is this something I need to do to prevent it from dropping more than it does now...?

@camc314
Copy link
Collaborator

camc314 commented Jan 9, 2024

Sorry i meant to merge this 🙂 .

i think the code speed drop is fine - it looks slightly buggy e.g. #1965 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants