fix(linter): fix plugin name parsing when reading config file #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1972 will degrade performances by 6.36%Comparing Summary
Benchmarks breakdown
|
|
Thank you! |
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this pull request
May 29, 2024
…oject#1972) This PR fixes the plugin parsing logic when reading a config file. Specifically, the plugin names defined in `RuleEnum`s use snake-case ("jsx_a11y") while in the config file they are written as "jsx-a11y". This inconsistency causes some rules to be filtered out. I tested the change with the config json file provided in oxc-project#1969. - Before the change: `Finished in 21ms on 1 file with 157 rules using 8 threads.` - After the change: `Finished in 23ms on 1 file with 178 rules using 8 threads.` Related issue: oxc-project#1969
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the plugin parsing logic when reading a config file.
Specifically, the plugin names defined in
RuleEnums use snake-case ("jsx_a11y") while in the config file they are written as "jsx-a11y". This inconsistency causes some rules to be filtered out.I tested the change with the config json file provided in #1969.
Finished in 21ms on 1 file with 157 rules using 8 threads.Finished in 23ms on 1 file with 178 rules using 8 threads.Related issue: #1969