Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): handle anonymous functional components in arrays that have a function body #1983

Conversation

maurice
Copy link
Contributor

@maurice maurice commented Jan 10, 2024

Attempt to fix #1982.

Slightly simplified the code I added for my previous fix for #1857 in the process

@github-actions github-actions bot added the A-linter Area - Linter label Jan 10, 2024
@maurice maurice force-pushed the fix/jsx-key-with-more-complex-story-decorator branch from 7dfaf9c to ac59157 Compare January 10, 2024 21:09
Copy link

codspeed-hq bot commented Jan 10, 2024

CodSpeed Performance Report

Merging #1983 will not alter performance

Comparing maurice:fix/jsx-key-with-more-complex-story-decorator (ac59157) with main (78b427b)

Summary

✅ 14 untouched benchmarks

Copy link
Collaborator

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@camc314 camc314 merged commit d4acd14 into oxc-project:main Jan 10, 2024
16 checks passed
@maurice maurice deleted the fix/jsx-key-with-more-complex-story-decorator branch January 11, 2024 09:36
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive - eslint-plugin-react(jsx-key): Missing "key" prop for element in array. (again)
2 participants