Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter) fix false positive for erasing-op in 0/0 case #2009

Merged

Conversation

camc314
Copy link
Collaborator

@camc314 camc314 commented Jan 12, 2024

i wonder whether we should have a rule for prefering NaN over 0/0

Copy link
Collaborator Author

camc314 commented Jan 12, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions bot added the A-linter Area - Linter label Jan 12, 2024
Copy link

codspeed-hq bot commented Jan 12, 2024

CodSpeed Performance Report

Merging #2009 will not alter performance

Comparing c/01-12-fix_linter_fix_false_positive_for_erasing-op_in_0/0_case (d699f7a) with main (712e99c)

Summary

✅ 14 untouched benchmarks

@Boshen Boshen merged commit 107a32e into main Jan 13, 2024
17 checks passed
@Boshen Boshen deleted the c/01-12-fix_linter_fix_false_positive_for_erasing-op_in_0/0_case branch January 13, 2024 02:32
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants