Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): improve no_redeclare rule implementation #2084

Merged

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jan 19, 2024

No description provided.

@github-actions github-actions bot added A-linter Area - Linter A-semantic Area - Semantic labels Jan 19, 2024
@Dunqing
Copy link
Member Author

Dunqing commented Jan 19, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@Dunqing Dunqing changed the title feat(linter): improve no_redeclare rule implemenetation feat(linter): improve no_redeclare rule implementation Jan 19, 2024
Copy link

codspeed-hq bot commented Jan 19, 2024

CodSpeed Performance Report

Merging #2084 will not alter performance

Comparing 01-19-feat_linter_improve_no_redeclare_rule_implemenetation (45dffcc) with main (60ab712)

Summary

✅ 14 untouched benchmarks

@Dunqing
Copy link
Member Author

Dunqing commented Jan 19, 2024

image

We still get a 4% performance improvement in the pdf.js benchmark

@Boshen
Copy link
Member

Boshen commented Jan 19, 2024

Can you test this in other codebases?

I assume you have a folder of codebases to test lint rules :-), if not:

https://github.com/oxc-project/oxc/blob/main/MAINTENANCE.md#release-linter

oxlint -D no-redeclare

@Boshen
Copy link
Member

Boshen commented Jan 19, 2024

Feel free to merge once you have tested this PR in real codebases.

@Dunqing
Copy link
Member Author

Dunqing commented Jan 19, 2024

image

The #2010 caused a panic.

@Dunqing
Copy link
Member Author

Dunqing commented Jan 19, 2024

I have tested it, and the report message is expected. I think we can good to merge it.

@Dunqing Dunqing merged commit 721a869 into main Jan 19, 2024
18 checks passed
@Dunqing Dunqing deleted the 01-19-feat_linter_improve_no_redeclare_rule_implemenetation branch January 19, 2024 12:10
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter A-semantic Area - Semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants