feat(linter): implement isolated_declaration #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't go too hard on this, probably an implementation on R1 should be more than enough for us to showcase our ability. |
|
One cool way for the exports is to mark the node with an Export flag, just like how we did it with Class. This may make your implementation easier. |
YangchenYe323
force-pushed
the
feat/isolated_declaration
branch
from
4018758
to
9906467
Compare
|
What's happening with the github action? |
YangchenYe323
changed the title
It's fixed. |
|
Good work! I like how the semantic analyzer is shaping out, the details are getting similar to Typescript, which is a good. |
YangchenYe323
force-pushed
the
feat/isolated_declaration
branch
from
9906467
to
63fdbfc
Compare
|
Thank you! I made some small modifications on main, I'll make a release soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement restrictions for isolated_declaration in #207