Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): use correct rule name #2169

Merged
merged 8 commits into from
Jan 25, 2024
Merged

fix(linter): use correct rule name #2169

merged 8 commits into from
Jan 25, 2024

Conversation

leaysgur
Copy link
Collaborator

@leaysgur leaysgur commented Jan 25, 2024

Found by accident but it should be.


+1,

@github-actions github-actions bot added the A-linter Area - Linter label Jan 25, 2024
Copy link

codspeed-hq bot commented Jan 25, 2024

CodSpeed Performance Report

Merging #2169 will not alter performance

Comparing linter/fix-naming (683aa6b) with main (989ab88)

Summary

✅ 17 untouched benchmarks

@Boshen Boshen merged commit c18619e into main Jan 25, 2024
19 checks passed
@Boshen Boshen deleted the linter/fix-naming branch January 25, 2024 08:54
@Boshen
Copy link
Member

Boshen commented Jan 25, 2024

Nice find!

Should remove it..?

Yes, I'll remove it.

IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
Found by accident but it should be.

- [x] react/jsx-no-comment-text-nodes
  - `jsx-no-comment-textnodes` is correct
-
https://github.com/jsx-eslint/eslint-plugin-react/blob/master/lib/rules/jsx-no-comment-textnodes.js
- [x] react/no-dangerously-set-inner-html
  - `no-danger` is correct
-
https://github.com/jsx-eslint/eslint-plugin-react/blob/master/lib/rules/no-danger.js
- [x] react-perf/no-jsx-as-prop
  - Correct name has `jsx-` prefix
-
https://github.com/cvazac/eslint-plugin-react-perf/tree/master/lib/rules
- [x] react-perf/no-new-array-as-prop
  - The same as above
- [x] react-perf/no-new-function-as-props
  - The same as above
- [x] react-perf/no-new-object-as-prop
  - The same as above
- [x] jsx-a11y/tab-index-no-positive
  - `tabindex-no-positive` is correct
-
https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/src/rules/tabindex-no-positive.js
- [x] jsx-a11y/role-support-aria-props
  - `role-suports-aria-props` is correct
-
https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/src/rules/role-supports-aria-props.js

- - - 

+1, 

- typescript/consistent-type-exports
- Listed in `disable-type-checked` config == This is type checking rule
but implemented
-
https://github.com/typescript-eslint/typescript-eslint/blob/8622286207b3e04ddd260eaa8ac71927d47edd7d/packages/eslint-plugin/src/configs/disable-type-checked.ts#L12
  - Should remove it..?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants