Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip early error check for ts definition #219

Merged

Conversation

mysteryven
Copy link
Member

fix: #214

@Boshen
Copy link
Member

Boshen commented Mar 28, 2023

Thank you for the PR!

Does it make sense to not check .d.ts at all? We can filter it out if this is the case.

https://github.com/Boshen/oxc/blob/3e3cbec1a8a303bae90d71dc79c425958f85d70e/crates/oxc_cli/src/lint/runner.rs#L120-L123

@Boshen
Copy link
Member

Boshen commented Mar 28, 2023

Thank you for sponsoring as well! Much appreciated 😁

@mysteryven
Copy link
Member Author

mysteryven commented Mar 28, 2023

Thank you for sponsoring as well! Much appreciated 😁

I really enjoy your JavaScript parser tutorial, I admire your selflessness in contributing to open source community and helping others without expecting anything in return! You are a role model for me!!!

@mysteryven
Copy link
Member Author

Does it make sense to not check .d.ts at all

Maybe people create global.d.ts for global scope:

interface myLib {
  arr: Array<string>;
       ^^^ Array type using 'Array<string>' is forbidden. Use 'string[]' instead.
}

Playground

@Boshen
Copy link
Member

Boshen commented Mar 28, 2023

Does it make sense to not check .d.ts at all

Maybe people create global.d.ts for global scope:

interface myLib {
  arr: Array<string>;
       ^^^ Array type using 'Array<string>' is forbidden. Use 'string[]' instead.
}

Playground

Ok, let's merge and see how this turns out. Can you rebase to get the CI going?

@mysteryven mysteryven closed this Mar 28, 2023
@mysteryven mysteryven force-pushed the fix/disable-early-checks-for-ts-definition branch from 91b7e58 to 3e3cbec Compare March 28, 2023 02:57
@mysteryven mysteryven reopened this Mar 28, 2023
@mysteryven mysteryven marked this pull request as ready for review March 28, 2023 03:09
@Boshen Boshen merged commit 48385f4 into oxc-project:main Mar 28, 2023
@Boshen
Copy link
Member

Boshen commented Mar 28, 2023

Thank you for your first contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(linter): need to disable all early checks in .d.ts
2 participants