feat(linter): implement eslint(array-callback-return) #221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried implementing array-callback-return discussed in #218 based purely on AST.
I couldn't find an easy way to use the
Visit
trait for our task, i.e, given aStatement
, find out whether it will return explicitly on all paths. The structure is like this (takeIfStatement
as an example):The check for switch statement is even more complex with a lot of local computations.
Wonder if this can be translated to use the
Visit
trait and store the on-stack local states somewhere in the visitor.