Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ast): remove expression property from Function #2247

Merged
merged 1 commit into from
Feb 1, 2024
Merged

feat(ast): remove expression property from Function #2247

merged 1 commit into from
Feb 1, 2024

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Feb 1, 2024

No description provided.

@Dunqing
Copy link
Member Author

Dunqing commented Feb 1, 2024 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@Dunqing Dunqing mentioned this pull request Feb 1, 2024
Merged
@github-actions github-actions bot added A-parser Area - Parser A-ast Area - AST A-transformer Area - Transformer / Transpiler labels Feb 1, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 1, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #2247 will not alter performance

Comparing 02-01-feat_ast_remove_expression_property_from_Function (62d0e14) with main (02c18d8)

Summary

✅ 17 untouched benchmarks

@Dunqing
Copy link
Member Author

Dunqing commented Feb 1, 2024 •
edited
Loading

Merge activity

  • Feb 1, 2:19 AM EST America/New_York: @Dunqing started a stack merge that includes this pull request via Graphite.
  • Feb 1, 2:19 AM EST America/New_York: Graphite rebased this pull request as part of a merge.
  • Feb 1, 2:23 AM EST America/New_York: @Dunqing merged this pull request with Graphite.

Base automatically changed from 02-01-feat_transformer/decorators_support_for_static_and_private_member_decorators to main February 1, 2024 07:19
@Dunqing Dunqing force-pushed the 02-01-feat_ast_remove_expression_property_from_Function branch from 3a53460 to 62d0e14 Compare February 1, 2024 07:19
@Dunqing Dunqing merged commit 165f948 into main Feb 1, 2024
20 checks passed
@Dunqing Dunqing deleted the 02-01-feat_ast_remove_expression_property_from_Function branch February 1, 2024 07:23
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
@Dunqing @IWANABETHATGUY
feat(ast): remove expression property from Function (oxc-project#2247)
74bc18f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen approved these changes

Assignees
No one assigned
Labels
A-ast Area - AST A-parser Area - Parser A-transformer Area - Transformer / Transpiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dunqing @Boshen