Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): add no-bitwise rule #228

Merged
merged 6 commits into from
Mar 31, 2023
Merged

feat(linter): add no-bitwise rule #228

merged 6 commits into from
Mar 31, 2023

Conversation

mysteryven
Copy link
Member

feat: #227

@mysteryven
Copy link
Member Author

I'll go over the code details tonight and create a draft of PR for now

@Boshen
Copy link
Member

Boshen commented Mar 31, 2023 •
edited
Loading

It seems we have a misunderstanding here,

bad-bitwise-operator is from deepscan, where it forbids bitwise in certain constructs.
no-bitwsise is for forbidding all bitwise operations.

This is why bad-bitwise-operator can be categoriezed as correctness. And no-bitwsise is not a recommended rule in ESLint.

@mysteryven mysteryven closed this Mar 31, 2023
@Boshen
Copy link
Member

Boshen commented Mar 31, 2023

We can put this under nursery.

@Boshen Boshen reopened this Mar 31, 2023
Boshen
Boshen requested changes Mar 31, 2023
View reviewed changes
crates/oxc_linter/src/rules/no_bitwise.rs Outdated Show resolved Hide resolved
crates/oxc_linter/src/rules/no_bitwise.rs Show resolved Hide resolved
crates/oxc_linter/src/snapshots/no_bitwise.snap Show resolved Hide resolved
crates/oxc_linter/src/rules/no_bitwise.rs Outdated Show resolved Hide resolved
@Boshen Boshen marked this pull request as ready for review March 31, 2023 15:36
Boshen
Boshen requested changes Mar 31, 2023
View reviewed changes
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last small change and we'll be able to merge.

@Boshen Boshen merged commit 20693dc into oxc-project:main Mar 31, 2023
@Boshen
Copy link
Member

Boshen commented Mar 31, 2023

Thank you so much!

@Boshen Boshen mentioned this pull request Mar 31, 2023
Closed
@mysteryven mysteryven deleted the feat/bad-bitwise-operator branch March 31, 2023 23:32
@Boshen Boshen added this to the 0.0.3 milestone Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mysteryven @Boshen