feat(span): fix memory leak by implementing inlineable string for oxc_allocator #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oxc canceled.
|
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
CodSpeed Performance ReportMerging #2294 will degrade performances by 7.7%Comparing Summary
Benchmarks breakdown
|
Boshen
force-pushed
the
02-04-feat_span_implement_inlineable_string_oxc_allocator
branch
from
8d4b0ef
to
ba1e860
Compare
…_allocator closes #1803 This `String` is currently unsafe, but I won't to get miri working before introducing more changes.
Boshen
force-pushed
the
02-04-feat_span_implement_inlineable_string_oxc_allocator
branch
from
ba1e860
to
9099d5c
Compare
Boshen
deleted the
02-04-feat_span_implement_inlineable_string_oxc_allocator
branch
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this pull request
May 29, 2024
…_allocator (oxc-project#2294) closes oxc-project#1803 This string is currently unsafe, but I want to get miri working before introducing more changes. I want to make a progress from memory leak to unsafe then to safety. It's harder to do the steps in one go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1803
This string is currently unsafe, but I want to get miri working before introducing more changes.
I want to make a progress from memory leak to unsafe then to safety. It's harder to do the steps in one go.