perf(parser): optimize lexing strings

[overlookmotel]

Optimize lexing strings a bit.

[overlookmotel]

Current dependencies on/for this PR:

• main
  • PR perf(parser): optimize lexing strings #2366 👈

This stack of pull requests is managed by Graphite.

[codspeed-hq]

CodSpeed Performance Report

Merging #2366 will improve performances by 4.83%

_{Comparing 02-09-perf_parser_optimize_lexing_strings (38b7d79) with main (d6d921e)}

Summary

⚡ 1 improvements
✅ 26 untouched benchmarks

Benchmarks breakdown

	Benchmark	main	02-09-perf_parser_optimize_lexing_strings	Change
⚡	lexer[cal.com.tsx]	33 ms	31.5 ms	+4.83%

[overlookmotel]

This is as good as I can do for now. Still a bit disappointing, but ready for merge now if you're willing.

As discussed on #2353, the increasing use of macros may be a concern. But could we go with it for now? If we introduce SIMD, or implement #2368, the macro will change a lot, and it'd be easier to keep those changes in one place (the macro) until it's fairly locked. At that point, as you said, if the macros slow down compilation we could expand them all manually.

[Boshen]

But could we go with it for now?

Of course! Improve then refactor.

[overlookmotel]

Of course! Improve then refactor.

Thanks Boshen!