New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(linter): fix panic when directive appears at the first line #264

Merged

Boshen merged 1 commit into oxc-project:main from yesmeck:fix-directive-parsing

Apr 6, 2023

Contributor

yesmeck commented Apr 6, 2023 •

edited

Loading

Span is 0-based, while length is 1-based, so when a directive appears at the first line, subtracting the span by the length can lead to an overflow.


          fix(linter): fix panic when directive appears at the first line

f58c28c

Boshen merged commit 034ca98 into oxc-project:main

Member

Boshen commented Apr 6, 2023

Thank you!

yesmeck deleted the fix-directive-parsing branch

April 6, 2023 13:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment