Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linter,semantic): move syntax check from linter to semantic #272

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Apr 9, 2023

Syntax checker is part of semantic analyzer,
it doesn't make sense for the user to add a linter just for semantic errors

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2023

Benchmark Results

Linux

group                      main                                   pr
-----                      ----                                   --
parser/babylon.max.js      1.00    105.0±0.21ms    98.3 MB/sec    1.02    106.6±0.19ms    96.8 MB/sec
parser/d3.js               1.00     13.4±0.04ms    40.6 MB/sec    1.01     13.5±0.03ms    40.4 MB/sec
parser/lodash.js           1.00      3.8±0.06ms   136.8 MB/sec    1.01      3.8±0.07ms   135.6 MB/sec
parser/pdf.js              1.00      7.4±0.12ms    54.3 MB/sec    1.01      7.5±0.14ms    53.8 MB/sec
parser/typescript.js       1.00    106.9±0.24ms    90.0 MB/sec    1.01    108.5±0.23ms    88.7 MB/sec
semantic/babylon.max.js    1.00    227.2±1.49ms    45.4 MB/sec    1.01    230.6±1.25ms    44.8 MB/sec
semantic/d3.js             1.00     27.2±1.45ms    20.0 MB/sec    1.04     28.3±3.28ms    19.3 MB/sec
semantic/lodash.js         1.15      6.6±0.16ms    78.1 MB/sec    1.00      5.7±0.16ms    89.7 MB/sec
semantic/pdf.js            1.09     14.7±0.63ms    27.4 MB/sec    1.00     13.5±1.52ms    29.8 MB/sec
semantic/typescript.js     1.00    187.2±3.12ms    51.4 MB/sec    1.02    190.3±1.39ms    50.6 MB/sec

Windows

group                      main                                   pr
-----                      ----                                   --
parser/babylon.max.js      1.00    123.9±1.38ms    83.4 MB/sec    1.03    127.5±3.37ms    81.0 MB/sec
parser/d3.js               1.00     15.4±0.14ms    35.6 MB/sec    1.03     15.9±0.48ms    34.4 MB/sec
parser/lodash.js           1.00      4.2±0.17ms   121.0 MB/sec    1.03      4.4±0.25ms   117.4 MB/sec
parser/pdf.js              1.00      8.5±0.12ms    47.3 MB/sec    1.04      8.9±0.32ms    45.3 MB/sec
parser/typescript.js       1.00    125.4±1.46ms    76.7 MB/sec    1.03    129.4±7.33ms    74.4 MB/sec
semantic/babylon.max.js    1.01    271.9±8.73ms    38.0 MB/sec    1.00    270.3±7.79ms    38.2 MB/sec
semantic/d3.js             1.00     32.9±0.49ms    16.6 MB/sec    1.09     36.0±1.60ms    15.2 MB/sec
semantic/lodash.js         1.02      6.7±0.12ms    77.2 MB/sec    1.00      6.5±0.10ms    79.0 MB/sec
semantic/pdf.js            1.00     14.3±0.27ms    28.2 MB/sec    1.04     14.8±0.41ms    27.2 MB/sec
semantic/typescript.js     1.00    236.4±3.40ms    40.7 MB/sec    1.05   247.9±12.14ms    38.8 MB/sec

@Boshen
Copy link
Member Author

Boshen commented Apr 9, 2023

The syntax checks are not part of the benchmark yet, I need to refactor it down a bit more.

Syntax checker is part of semantic analyzer,
it doesn't make sense for the user to add a linter just for semantic errors
@Boshen Boshen merged commit aedaa1a into main Apr 10, 2023
@Boshen Boshen deleted the checker branch April 10, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant