-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add oxc sourcemap crate #2825
Conversation
CodSpeed Performance ReportMerging #2825 will degrade performances by 3.84%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really hard to review, can you comment in the places where we should take a look?
cbb6f9f
to
8dd3681
Compare
Yeah. The code is larger to review, because the most code is port from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to run just fmt
.
The sourcemap implement port from rust-sourcemap, but has some different with it.
sourceContent
and encode token tovlq
mappings.Sourcemap
some methods overhead, likeSourceMap::tokens()
caused extra overhead at common cases. Here usingSourceViewToken
to instead of it.