Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transformer/jsx-source): get the correct lineNumber and columnNumber from the span. #3142

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Apr 30, 2024

No description provided.

Copy link
Member Author

Dunqing commented Apr 30, 2024

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Apr 30, 2024
Copy link

codspeed-hq bot commented Apr 30, 2024

CodSpeed Performance Report

Merging #3142 will not alter performance

Comparing 04-30-feat_transformer_jsx-source_get_the_correct_linenumber_and_columnnumber_from_the_span (9db9590) with main (f5dccc9)

Summary

✅ 30 untouched benchmarks

crates/oxc_span/src/span.rs Outdated Show resolved Hide resolved
Base automatically changed from 04-30-feat_transformer_react_enable_jsx_plugin_when_development_is_true to main April 30, 2024 07:48
@Dunqing Dunqing force-pushed the 04-30-feat_transformer_jsx-source_get_the_correct_linenumber_and_columnnumber_from_the_span branch from 1f0c7d6 to 86d8592 Compare April 30, 2024 08:12
@github-actions github-actions bot added the A-ast Area - AST label Apr 30, 2024
@Boshen Boshen force-pushed the 04-30-feat_transformer_jsx-source_get_the_correct_linenumber_and_columnnumber_from_the_span branch from 86d8592 to 9db9590 Compare May 1, 2024 00:27
@Boshen Boshen enabled auto-merge (squash) May 1, 2024 00:28
@Boshen Boshen merged commit a52e321 into main May 1, 2024
29 checks passed
@Boshen Boshen deleted the 04-30-feat_transformer_jsx-source_get_the_correct_linenumber_and_columnnumber_from_the_span branch May 1, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants