Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oxc_ast): add RegExpFlags bitflag for storing regex flags #32

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Feb 21, 2023

This reduces TokenValue from 56 to 40 bytes, Token from 72 to 56 bytes.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2023

Parser Benchmark Results

group                    main                                   pr
-----                    ----                                   --
parser/babylon.max.js    1.01    147.8±4.31ms    69.9 MB/sec    1.00    146.8±4.79ms    70.4 MB/sec
parser/d3.js             1.00     18.4±0.49ms    29.6 MB/sec    1.00     18.5±0.47ms    29.5 MB/sec
parser/lodash.js         1.00      5.2±0.28ms    98.0 MB/sec    1.00      5.3±0.19ms    97.8 MB/sec
parser/pdf.js            1.02     10.7±0.37ms    37.5 MB/sec    1.00     10.5±0.29ms    38.1 MB/sec
parser/typescript.js     1.00    146.2±2.90ms    65.8 MB/sec    1.00    146.4±3.58ms    65.7 MB/sec

This reduces `TokenValue` from 56 to 40 bytes, `Token` from 72 to 56 bytes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant