Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(semantic/cfg): add explicit break block element. #3223

Merged

Conversation

rzvxa
Copy link
Collaborator

@rzvxa rzvxa commented May 10, 2024

Works similar to how throw is working but is done for break statements.

@github-actions github-actions bot added A-linter Area - Linter A-semantic Area - Semantic labels May 10, 2024
@rzvxa rzvxa changed the title improvement(semantic): add explicit break block element. improvement(semantic/cfg): add explicit break block element. May 10, 2024
Copy link

codspeed-hq bot commented May 10, 2024

CodSpeed Performance Report

Merging #3223 will improve performances by 5.63%

Comparing 05-10-improvement_semantic_add_explicit_break_block_element (7e78502) with main (5e36e0d)

Summary

⚡ 1 improvements
✅ 26 untouched benchmarks

Benchmarks breakdown

Benchmark main 05-10-improvement_semantic_add_explicit_break_block_element Change
semantic[pdf.mjs] 144.2 ms 136.6 ms +5.63%

@rzvxa rzvxa force-pushed the 05-10-improvement_semantic_add_explicit_break_block_element branch 2 times, most recently from e3171a0 to 0812788 Compare May 10, 2024 13:05
@rzvxa rzvxa marked this pull request as ready for review May 10, 2024 13:15
Copy link
Member

Boshen commented May 10, 2024

Merge activity

  • May 10, 10:11 AM EDT: @Boshen started a stack merge that includes this pull request via Graphite.
  • May 10, 10:18 AM EDT: Graphite rebased this pull request as part of a merge.
  • May 10, 10:22 AM EDT: @Boshen merged this pull request with Graphite.

@Boshen Boshen force-pushed the 04-29-fix_semantic_add_cfg_nodes_for_conditionalexpression_s branch from 1e0b8bc to 541a9b9 Compare May 10, 2024 14:11
Base automatically changed from 04-29-fix_semantic_add_cfg_nodes_for_conditionalexpression_s to main May 10, 2024 14:16
@Boshen Boshen force-pushed the 05-10-improvement_semantic_add_explicit_break_block_element branch from 1a2657b to 7e78502 Compare May 10, 2024 14:17
@Boshen Boshen merged commit 20f6430 into main May 10, 2024
29 checks passed
@Boshen Boshen deleted the 05-10-improvement_semantic_add_explicit_break_block_element branch May 10, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter A-semantic Area - Semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants