Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter/react): rules_of_hooks resolve false positives with conditional hooks. #3299

Conversation

rzvxa
Copy link
Collaborator

@rzvxa rzvxa commented May 16, 2024

related to #3071

Copy link

graphite-app bot commented May 16, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label May 16, 2024
Copy link

codspeed-hq bot commented May 16, 2024

CodSpeed Performance Report

Merging #3299 will not alter performance

Comparing 05-16-fix_linter_react_rules_of_hooks_resolve_false_positives_with_conditional_hooks (c8f1f79) with main (6dcfc13)

Summary

✅ 27 untouched benchmarks

Copy link

graphite-app bot commented May 16, 2024

Merge activity

@Boshen Boshen force-pushed the 05-16-fix_linter_react_rules_of_hooks_resolve_false_positives_with_conditional_hooks branch from 9965994 to c8f1f79 Compare May 16, 2024 16:16
@graphite-app graphite-app bot merged commit c8f1f79 into main May 16, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 05-16-fix_linter_react_rules_of_hooks_resolve_false_positives_with_conditional_hooks branch May 16, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant