refactor(traverse): Traverse produce scopes tree using Semantic

[overlookmotel]

Traverse use Semantic to construct scopes tree and expose it to visitors via TraverseCtx.

Currently scopes tree is immutable. Will expose it as a mutable in a follow-on.

This is extremely inefficient. Semantic does all kinds of stuff (control flow graph etc) which Traverse doesn't need, and Traverse just throws away all that work after semantic has done it. Intent here is to get a working implementation first, and then to do another pass later on to improve performance.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[overlookmotel]

• feat(traverse): mutable access to scopes tree + symbol table #3314
• feat(traverse): pass &mut TraverseCtx to visitors #3312
• refactor(traverse): move parent method etc into TraverseAncestry #3308
• refactor(traverse): Traverse produce scopes tree using Semantic #3304 👈
• refactor(semantic): semantic populate scope_id fields in AST #3303
• refactor(ast): store ScopeId in AST nodes #3302
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #3304 will degrade performances by 66.05%

_{Comparing 05-16-refactor_traverse_traverse_produce_scopes_tree_using_semantic_ (05c71d2) with main (c8f1f79)}

Summary

❌ 5 regressions
✅ 22 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	main	05-16-refactor_traverse_traverse_produce_scopes_tree_using_semantic_	Change
❌	transformer[RadixUIAdoptionSection.jsx]	530 µs	970.8 µs	-45.41%
❌	transformer[antd.js]	653.3 ms	1,605.8 ms	-59.32%
❌	transformer[cal.com.tsx]	159.2 ms	391.4 ms	-59.32%
❌	transformer[checker.ts]	341.7 ms	1,006.6 ms	-66.05%
❌	transformer[pdf.mjs]	105.1 ms	282.9 ms	-62.86%

[graphite-app]

Merge activity

• May 16, 12:19 PM EDT: Boshen added this pull request to the Graphite merge queue.
• May 16, 12:31 PM EDT: Boshen merged this pull request with the Graphite merge queue.