Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(semantic): incorrect reference flag for TSTypeParameter #3441

Draft
wants to merge 6 commits into
base: 05-27-feat_ast_traverse_add_scope_for_tstypeparameter_tstypeinterfacedeclarration_and_tstypealiasdeclaration
Choose a base branch
from

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented May 27, 2024

Supersedes #2070

fix: #2023

ScopeFlags::TypeParameters is used to wrap all type parameters. This way we can find the parameters of the TypeParameterDeclaration when resolving the reference.

There may be a better solution, but I haven't thought of it yet

Copy link

graphite-app bot commented May 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Dunqing commented May 27, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-semantic Area - Semantic label May 27, 2024
@Dunqing Dunqing changed the title fix(semantic): incorrect reference flag for TSTypeParameter feat(transformer): support targets option of preset-env May 27, 2024
@Dunqing Dunqing changed the title feat(transformer): support targets option of preset-env fix(semantic): incorrect reference flag for TSTypeParameter May 27, 2024
Copy link

codspeed-hq bot commented May 27, 2024

CodSpeed Performance Report

Merging #3441 will not alter performance

Comparing 05-28-fix_semantic_incorrect_reference_flag_for_tstypeparameter (6d26eb2) with 05-27-feat_ast_traverse_add_scope_for_tstypeparameter_tstypeinterfacedeclarration_and_tstypealiasdeclaration (04cbf1d)

Summary

✅ 22 untouched benchmarks

@Dunqing Dunqing requested a review from Boshen May 28, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-semantic Area - Semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant