Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter/eslint): Implement no-multi-str #4038

Merged
merged 3 commits into from
Jul 6, 2024

Conversation

jelly
Copy link
Contributor

@jelly jelly commented Jul 2, 2024

Rule Detail:
link

@github-actions github-actions bot added the A-linter Area - Linter label Jul 2, 2024
Copy link

codspeed-hq bot commented Jul 2, 2024

CodSpeed Performance Report

Merging #4038 will not alter performance

Comparing jelly:eslint/no-multi-str (5df23e6) with main (7fe2a2f)

Summary

✅ 28 untouched benchmarks

@Boshen Boshen requested a review from mysteryven July 3, 2024 15:42
@mysteryven
Copy link
Member

Thanks for your patient, I want to merge this nice PR, so I made a tiny change about using find, hope you never mind.

@mysteryven mysteryven merged commit aa45604 into oxc-project:main Jul 6, 2024
25 checks passed
@jelly jelly deleted the eslint/no-multi-str branch July 6, 2024 15:10
@jelly
Copy link
Contributor Author

jelly commented Jul 6, 2024

Thanks for your patient, I want to merge this nice PR, so I made a tiny change about using find, hope you never mind.

No problem! Should have added a test :)

This was referenced Jul 7, 2024
Boshen added a commit that referenced this pull request Jul 7, 2024
## [0.5.3] - 2024-07-07

### Features

- 1681b11 linter: Eslint-plugin-jest/consistent-test-it (#4053)
(cinchen)
- 6876490 linter: Add rule no-undefined (#4041) (jordan boyer)
- bf04dee linter: Implement unicorn/no-negation-in-equality-check
(#4034) (Nissim Chekroun)
- aa45604 linter/eslint: Implement no-multi-str (#4038) (Jelle van der
Waa)

### Bug Fixes

- 7b2dc3b linter: Fix panic in import/namespace (#4080) (Boshen)

Co-authored-by: Boshen <Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants