-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(napi/transform): allow setting sourceType
to transform
#4113
feat(napi/transform): allow setting sourceType
to transform
#4113
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
2869e0e
to
2263f2f
Compare
## [0.17.2] - 2024-07-08 ### Features - 115ac3b allocator: Introduce `FromIn` and `IntoIn` traits. (#4088) (rzvxa) - 720983a napi/transform: Allow setting `sourceType` to `transform` (#4113) (Boshen) - e386b62 semantic: Check for invalid type import assignments (#4097) (DonIsaac) ### Bug Fixes - 5472b7c codegen: 256 indentations level is not enough for codegen (Boshen) - 5c31236 isolated-declarations: Keep literal value for readonly property (#4106) (Dunqing) - e67c7d1 isolated-declarations: Do not infer type for private parameters (#4105) (Dunqing) - 3fcad5e isolated_declarations: Remove nested AssignmentPatterns from inside parameters (#4077) (michaelm) - f8d77e4 isolated_declarations: Infer type of template literal expressions as string (#4068) (michaelm) - 0f02608 semantic: Bind `TSImportEqualsDeclaration`s (#4100) (Don Isaac) - 4413e2d transformer: Missing initializer for readonly consructor properties (#4103) (Don Isaac) ### Performance - 7ed27b7 isolated-declarations: Use `FxHashSet` instead of `Vec` to speed up the `contain` (#4074) (Dunqing) - 9114c8e semantic: Keep a single map of unresolved references (#4107) (Luca Bruno) Co-authored-by: Boshen <Boshen@users.noreply.github.com>
CodSpeed Performance ReportMerging #4113 will not alter performanceComparing Summary
|
let source_path = Path::new(&filename); | ||
let source_type = SourceType::from_path(source_path).unwrap_or_default(); | ||
let source_type = SourceType::from_path(&filename).unwrap_or_default(); | ||
let source_type = match options.as_ref().and_then(|options| options.source_type.as_deref()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @Boshen Here maybe need to pass tsx
Extention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why? what's the usecase?
closes #4071