feat(linter): eslint/no-loss-of-precision

[Devin-Yeung]

Close #613

[CLAassistant]

All committers have signed the CLA.

[Boshen]

This rule can be slow due to all the allocations, we may need to add a bunch of Cow to reduce some allocations.

[Devin-Yeung]

Some minor fixes are done, I will try my best to reduce the number of string allocations to improve the performance

[Devin-Yeung]

I am not familiar with Cow, so I may misuse some APIs, any advice is appreciated 🙇‍♂️

[Boshen]

@Devin-Yeung This rule is currently the slowest, twice as slow compared to all the others rules. Are you intrested in doing some performance work for this rule?

[Boshen]

Timing from 52k files.

[Devin-Yeung]

@Devin-Yeung This rule is currently the slowest, twice as slow compared to all the others rules. Are you intrested in doing some performance work for this rule?

It seems that the regex call is very expensive, maybe we can parse the number manually to get better performance. But unfortunately I haven't had much time to be able to deal with this lately😢. Should we consider opening an issue to invite anyone interested to collaborate on this?

[Boshen]

@Devin-Yeung This rule is currently the slowest, twice as slow compared to all the others rules. Are you intrested in doing some performance work for this rule?

It seems that the regex call is very expensive, maybe we can parse the number manually to get better performance. But unfortunately I haven't had much time to be able to deal with this lately😢. Should we consider opening an issue to invite anyone interested to collaborate on this?

I'll create a first good issue when we have found a viable solution, otherwise it may waste people's time :-(

[Devin-Yeung]

I'll create a first good issue when we have found a viable solution, otherwise it may waste people's time :-(

Agreed, I'm also not sure how much of a performance gain manual parsing would bring about 🤔

[Maneren]

Agreed, I'm also not sure how much of a performance gain manual parsing would bring about 🤔

Around 1.5-2x speedup of the rule on my machine on babel and typescript codebases, bringing it to times similar to the other slow rules. I'll clean up the code and send a PR.