Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RootsPlugin debug_assert on windows #145

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Apr 24, 2024

@ahabhgk ahabhgk changed the title fix: RootsPlugin on windows fix: RootsPlugin debug_assert on windows Apr 24, 2024
@ahabhgk ahabhgk marked this pull request as ready for review April 24, 2024 09:45
@Boshen
Copy link
Member

Boshen commented Apr 24, 2024

Do we have a failing test case?

@Boshen Boshen self-requested a review April 24, 2024 10:44
src/lib.rs Show resolved Hide resolved
@ahabhgk
Copy link
Contributor Author

ahabhgk commented Apr 24, 2024

Screenshot 2024-04-24 at 19 04 23 Yes, in the previous PR (https://github.com/oxc-project/oxc-resolver/actions/runs/8812076020/job/24187103817#step:5:242) the debug_assert panic on windows, don't know why it passes in CI

@Boshen
Copy link
Member

Boshen commented Apr 24, 2024

Screenshot 2024-04-24 at 19 04 23 Yes, in the previous PR (https://github.com/oxc-project/oxc-resolver/actions/runs/8812076020/job/24187103817#step:5:242) the debug_assert panic on windows, don't know why it passes in CI

Let me fix the CI

Copy link

codspeed-hq bot commented Apr 24, 2024

CodSpeed Performance Report

Merging #145 will not alter performance

Comparing ahabhgk:fix-roots-win (3fab356) with main (3f082a5)

Summary

✅ 2 untouched benchmarks

@Boshen
Copy link
Member

Boshen commented Apr 24, 2024

Thank you!

@Boshen Boshen merged commit 7866055 into oxc-project:main Apr 24, 2024
18 checks passed
@ahabhgk ahabhgk deleted the fix-roots-win branch April 25, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants