Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-parse after running --fix #20

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

DonIsaac
Copy link

Related to, but does not fully address, #19.

NOTE: this PR also enables the vitest plugin

Adds a step to the test stage that re-runs oxlint after it was previously run with --fix. This should help us catch syntax errors created by buggy fixes.

We should also consider running typecheck scripts for repositories that have them.

Related to, but does not fully address, #19.

> NOTE: this PR also enables the vitest plugin

Adds a step to the test stage that re-runs oxlint after it was previously run
with `--fix`. This should help us catch syntax errors created by buggy fixes.

We should also consider running `typecheck` scripts for repositories that have
them.
@DonIsaac DonIsaac self-assigned this Jul 10, 2024
@DonIsaac
Copy link
Author

I'll continue debugging this later tonight.

@mysteryven
Copy link
Member

mysteryven commented Jul 11, 2024

Do we need add idempotence test in our local?

https://github.com/oxc-project/oxc/blob/main/crates/oxc_linter/src/tester.rs#L236-#L249

@DonIsaac
Copy link
Author

Anyone have any idea why this is failing? Am I doing something wrong?

@Boshen
Copy link
Member

Boshen commented Jul 20, 2024

It feels like something has crashed 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants