SIS Import: Support errorsAttachment objects to download SIS import f… #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpellicer
force-pushed
the
sis_import_errors
branch
from
9a6d1a0
to
da1e86e
Compare
buckett
reviewed
Sep 30, 2021
| * Class to represent Canvas Sis Imports Errors Attachment | ||
| * See <a href="https://canvas.instructure.com/doc/api/sis_imports.html#SisImport">SisImport</a> documentation. | ||
| */ | ||
| @CanvasObject(postKey = "errors_attachment") |
There was a problem hiding this comment.
I'm not sure you need the @CanvasObject and @CanvasField annotations as this object shouldn't ever be POSTed back to Canvas. The only place they are used is in edu.ksu.canvas.model.BaseCanvasModel when building POST request parameters.
There was a problem hiding this comment.
Yeah, pure imitation, let me address this and re-test, thanks @buckett.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ull error logs.