Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add calculate(string) function #67

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Add calculate(string) function #67

merged 3 commits into from
Dec 1, 2023

Conversation

Victorcorcos
Copy link
Contributor

@Victorcorcos Victorcorcos commented Nov 30, 2023 •
edited
Loading

Description ✍️

Upgrade equations-parser submodule in order to add the calculate(string) function, which evaluates the string input as an equation and calculates it's result.

Overview 🔍

Screen Shot 2023-11-30 at 01 16 32

Checks ☑️

  • Add calculate() tests
  • Add equations-parser changes
  • Update README.md

@Victorcorcos Victorcorcos self-assigned this Nov 30, 2023
EduardoRSeifert
EduardoRSeifert approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@EduardoRSeifert EduardoRSeifert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@tiagogoncalves tiagogoncalves merged commit 801d4cc into oxeanbits:master Dec 1, 2023
7 checks passed
@Victorcorcos Victorcorcos deleted the add_calculate_function branch December 4, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagogoncalves tiagogoncalves tiagogoncalves approved these changes

@EduardoRSeifert EduardoRSeifert EduardoRSeifert approved these changes

Assignees

@Victorcorcos Victorcorcos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Victorcorcos @tiagogoncalves @EduardoRSeifert