Fix assigning empty dicts/sets dirtying #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When assigning an empty set/dict to a location that doesn't currently exist, we'd dirty the config, assign the empty dict/set, but then when we produce the update it is unchanged because empty dicts/sets get pruned. This fixes it so that such assignment becomes an *erase* instead, since that what the final result will be.
jagerman
force-pushed
the
fix-empty-set-bug
branch
from
389fda9
to
b4e7c5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When assigning an empty set/dict to a location that doesn't currently exist, we'd dirty the config, assign the empty dict/set, but then when we produce the update it is unchanged because empty dicts/sets get pruned.
This fixes it so that such assignment becomes an erase instead, since that what the final result will be.