Fix plaintext size calculation #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciphertext has already been reduced by 1 + crypto_aead_xchacha20poly1305_ietf_NPUBBYTES at this point, but that wasn't being accounted for in the size calculations. (Thanks to @ftrget for finding this one!)
We were encrypting, but not testing that we can actually decrypt that message (and thus not catching the problem from the previous commit).
|
typo, should be @frtget instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ciphertext has already been reduced by 1 +
crypto_aead_xchacha20poly1305_ietf_NPUBBYTES at this point, but that wasn't being accounted for in the size calculations.
(Thanks to @ftrget for finding this one!)