feat: add make_dump() to ConfigBase and Keys classes #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rename it to |
jagerman
approved these changes
Sep 18, 2023
jagerman
changed the title
- rename `debug_dump` to `make_dump`, since it is also used internally (for non-debugging). - make it `const` to ensure we aren't mutating state. (And we were, with clearing old hashes: that is now done only by `dump()` but not `make_dump()`). - Update API documentation wording
jagerman
force-pushed
the
feat/add-debug-dump
branch
from
2c304bf
to
849d215
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.