Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various minor fixes (mostly comments) #64

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

Various minor fixes (mostly comments) #64

wants to merge 9 commits into from

Commits on Nov 21, 2023

  1. keys config C API fixes 

    - typo in function name
- return false when subaccount signing value verification throws
    @frtget
    frtget committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    f088d0a View commit details
    Browse the repository at this point in the history

  2. reserve enough memory to avoid extra copies in Keys::group_keys() whe… 

    …n there is a pending key
    @frtget
    frtget committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    98e5b5b View commit details
    Browse the repository at this point in the history

  3. try decrypting messages with most recent keys first

    @frtget
    frtget committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    60fbd69 View commit details
    Browse the repository at this point in the history

  4. make sure we use different hash keys in different contexts

    @frtget
    frtget committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    6d36252 View commit details
    Browse the repository at this point in the history

  5. fix broken sodium_ptr template and non-trivially-copyable type copy i… 

    …n sodium_array::load

we never enter the for loop in sodium_array::load because len is always equal to length after calling reset(length)
    @frtget
    frtget committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    cbf4f0a View commit details
    Browse the repository at this point in the history

  6. remove unused variable

    @frtget
    frtget committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    7755f67 View commit details
    Browse the repository at this point in the history

  7. fix some comments

    @frtget
    frtget committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    3d94b9d View commit details
    Browse the repository at this point in the history

  8. remove unnecessary includes and type aliases

    @frtget
    frtget committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    3e2407d View commit details
    Browse the repository at this point in the history

  9. format

    @frtget
    frtget committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    89c631e View commit details
    Browse the repository at this point in the history