Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent crash by removing duplicate logic #1515

Merged
merged 1 commit into from Jan 19, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion llarp/path/path_context.cpp
Expand Up @@ -320,7 +320,6 @@ namespace llarp
{
if (itr->second->Expired(now))
{
itr->second->m_PathSet->RemovePath(itr->second);
itr = map.erase(itr);
}
else
Expand Down
7 changes: 0 additions & 7 deletions llarp/path/pathset.cpp
Expand Up @@ -266,13 +266,6 @@ namespace llarp
}
}

void
PathSet::RemovePath(Path_ptr path)
{
Lock_t l(m_PathsMutex);
m_Paths.erase({path->Upstream(), path->RXID()});
}

Path_ptr
PathSet::GetByUpstream(RouterID remote, PathID_t rxid) const
{
Expand Down
3 changes: 0 additions & 3 deletions llarp/path/pathset.hpp
Expand Up @@ -119,9 +119,6 @@ namespace llarp
size_t
NumPathsExistingAt(llarp_time_t futureTime) const;

void
RemovePath(Path_ptr path);

virtual void
HandlePathBuilt(Path_ptr path) = 0;

Expand Down