Draft: Wire Protocol Overhaul, Message Handling Refactor #2204

dr7ana · 2023-08-29T14:28:00Z

No description provided.

llarp/util/buffer.hpp

llarp/router_contact.cpp

llarp/router/i_outbound_session_maker.hpp

llarp/router/abstractrouter.hpp

llarp/messages/link_message.hpp

llarp/dht/messages/pubintro.cpp

llarp/messages/common.hpp

- routing messages and surrounding code - shim code in place for iteration and optimization after deciding what to do with buffer, string handling, and subsequent function calls

- `::handle_message` is transposed; Rather than the message calling the method and taking a reference to the router, the router should have a handle_message method and take a reference to the message - `::EndcodeBuffer` takes a string reference, to which the result of `::bt_encode()` is assigned

- added CI fixes for gnutls build

- stupid warn deprecated stupid

RIP: - i_link_manager - i_outbound_message_handler - i_gossiper - i_outbound_session_maker - i_rc_lookup_handler

- RIP llarp/iwp/* and most of llarp/link

llarp/link/endpoint.cpp

llarp/link/link_manager.cpp

- bumped libquic to begin implementing dependent features on connection open/close signals - more gutting of interface classes

- llarp/router/router.hpp, route_poker, and platform code moved to libquic Address types - implementing required methods in link_manager for connection establishment - coming along nicely

- tons of surrounding stupid refactoring required

- free standing functions in link_manager - sign and serialize functionalities siloed in llarp/messages/exit.hpp

- implementing DHT message transmission methods and surrounding functionalities across paths

llarp/link/link_manager.cpp

llarp/util/aligned.hpp

- Reworking how paths to services and snodes - pushing for Tom to rebase for path handling

- Added call_get to ev.hpp to queue event loop operations w/ a return value - de-mutexed NodeDB and made all operations via event loop. Some calls to NodeDB methods (like ::put_if_newer) were wrapped in call->get's, but some weren't. All function bodies were using mutex locks

- mutexes in nodedb and rc_lookup_handler removed - implemented thread-safe queueing to event loop for previously locked accesses

jagerman · 2023-10-16T18:06:25Z

Merging into quic-wip not because it's done, but because that's already a WIP branch, and ought to make new additions/updates/reviews easier of more code going into quic-wip.

majestrate reviewed Aug 29, 2023

View reviewed changes

llarp/util/buffer.hpp Show resolved Hide resolved

majestrate reviewed Aug 29, 2023

View reviewed changes

dr7ana force-pushed the quic-wip branch 3 times, most recently from 45c2be3 to 1dc877e Compare August 30, 2023 19:15

mein gott

a921575

dr7ana force-pushed the quic-wip branch from 1dc877e to a921575 Compare August 30, 2023 19:25

majestrate reviewed Aug 30, 2023

View reviewed changes

llarp/dht/messages/pubintro.cpp Outdated Show resolved Hide resolved

llarp/messages/common.hpp Show resolved Hide resolved

dr7ana added 2 commits August 31, 2023 09:28

More message refactoring

11e54f6

- routing messages and surrounding code - shim code in place for iteration and optimization after deciding what to do with buffer, string handling, and subsequent function calls

dr7ana force-pushed the quic-wip branch from 03a0fb4 to cb18e64 Compare September 13, 2023 16:46

oxen-libquic version bump

0b6506a

- added CI fixes for gnutls build

dr7ana force-pushed the quic-wip branch from cb18e64 to 0b6506a Compare September 13, 2023 16:50

kitware CI deps

81aa044

- stupid warn deprecated stupid

dr7ana force-pushed the quic-wip branch from e23a760 to 81aa044 Compare September 13, 2023 17:16

dr7ana added 3 commits September 13, 2023 10:39

oxen-libquic update; no leak warn deprecated

7ce517b

warnings_as_errors fixes

821cbea

Nuked superfluous interface classes

7f8207d

RIP: - i_link_manager - i_outbound_message_handler - i_gossiper - i_outbound_session_maker - i_rc_lookup_handler

dr7ana force-pushed the quic-wip branch from 9427c02 to 7f8207d Compare September 13, 2023 20:35

dr7ana added 2 commits September 14, 2023 05:08

Added span backport

a4272c4

Zlib version bump 1.2.13 -> 1.3

d1b7eee

dr7ana mentioned this pull request Sep 14, 2023

out of date static dep #2206

Closed

dr7ana added 3 commits September 14, 2023 07:54

Carving through llarp/link

fd527d6

libquic bump

ffb90e8

Deleted a lot

aaf688c

- RIP llarp/iwp/* and most of llarp/link

dr7ana force-pushed the quic-wip branch from d5da638 to aaf688c Compare September 15, 2023 21:15

tewinget reviewed Sep 18, 2023

View reviewed changes

llarp/link/endpoint.cpp Outdated Show resolved Hide resolved

tewinget reviewed Sep 18, 2023

View reviewed changes

llarp/link/link_manager.cpp Outdated Show resolved Hide resolved

dr7ana added 2 commits September 18, 2023 14:50

More carving + libquic bump

bfa9629

- bumped libquic to begin implementing dependent features on connection open/close signals - more gutting of interface classes

Address type migration + libquic bump

a3e6cec

- llarp/router/router.hpp, route_poker, and platform code moved to libquic Address types - implementing required methods in link_manager for connection establishment - coming along nicely

dr7ana force-pushed the quic-wip branch 2 times, most recently from 9d172ec to 84bdee6 Compare October 2, 2023 20:06

Message method implementation continued

1a9f977

- tons of surrounding stupid refactoring required

dr7ana force-pushed the quic-wip branch from 84bdee6 to 09bb33a Compare October 3, 2023 20:00

wawaweewa

206bd0b

dr7ana force-pushed the quic-wip branch from 09bb33a to 206bd0b Compare October 3, 2023 20:11

tewinget and others added 2 commits October 4, 2023 04:17

refactor path build message construction, no more async nonsense

f35f7fe

following up before Tom meeting

4ed6a01

dr7ana force-pushed the quic-wip branch from c3f157d to 4ed6a01 Compare October 4, 2023 14:13

dr7ana and others added 3 commits October 6, 2023 08:35

Exit endpoints implemented

65bd224

- free standing functions in link_manager - sign and serialize functionalities siloed in llarp/messages/exit.hpp

Path message transmission

bd81357

- implementing DHT message transmission methods and surrounding functionalities across paths

handle path build requests, generate responses

2cc02d7