Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct cache behavior for multiple ONS name lookups. #1655

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

saravananp-001
Copy link

When multiple ONS names are provided in the lookup, the data is consistently updated in cache using the first name_hash instead of being appended with a new name_hash each time.

When multiple ONS names are provided in the lookup, the data is consistently updated in cache using the first name_hash instead of being appended with a new name_hash each time.
@darcys22
Copy link
Collaborator

darcys22 commented Sep 7, 2023

Thanks for the PR!

Is this compiling? Seeing this error in the CI

/drone/src/src/simplewallet/simplewallet.cpp: In member function 'bool cryptonote::simple_wallet::ons_lookup(std::vector<std::__cxx11::basic_string<char> >)':

/drone/src/src/simplewallet/simplewallet.cpp:7199:25: error: 'const class nlohmann::basic_json<>' has no member named 'name_hash'

 7199 |                 mapping.name_hash};

I suspect the difference is probably just needing to be mapping["name_hash"] as the json struct behaves differently to a regular c++ struct

error: 'const class nlohmann::basic_json<>' has no member named 'name_hash'

 7199 |                 mapping.name_hash};

resolved this error by replacing  mapping.name_hash with  mapping["name_hash"]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants