Simplified get_transfers and fixed sort segfault #890
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this is simplification while I stepped through the function:
for (x : list)
loop instead of manual iterator handlingargs.in
etc.: if they aren't specified the associated container will be empty anyway.(!((args.failed && is_failed) || (!is_failed && args.pending)))
with logically equivalent!(is_failed ? args.failed : args.pending)
(and then removed the negation, too).The segfault is fixed by the change inside the
sort
: because only the casea.confirmed && !b.confirmed
was handled but not the complement!a.confirmed && b.confirmed
you could get a case where twotransfer_view
s both compare earlier than each other.