Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix confirm tx popup inconsistency when sweeping all from service node tab #191

Merged
merged 6 commits into from Sep 22, 2020
Merged

Fix confirm tx popup inconsistency when sweeping all from service node tab #191

merged 6 commits into from Sep 22, 2020

Conversation

kylezs
Copy link

@kylezs kylezs commented Sep 22, 2020

No description provided.

@kylezs kylezs requested a review from Mikunj September 22, 2020 07:15
@kylezs kylezs mentioned this pull request Sep 22, 2020
Merged
Mikunj
Mikunj approved these changes Sep 22, 2020
View reviewed changes
Copy link

@Mikunj Mikunj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but i'm thinking maybe in the future it might be better when clicking sweep all to just direct the user to the send page with the relevant fields filled in. Will probably stop these weird bugs and also keep the code clean

@kylezs kylezs merged commit 9d55072 into oxen-io:development Sep 22, 2020
@kylezs kylezs deleted the logger branch October 15, 2020 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mikunj Mikunj Mikunj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kylezs @Mikunj