Signature value helpers #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seemed oddly positioned in the middle of consume_* functions.
This doesn't appear to have ever been used. It's also not something we really want to expose; the internal string_view is meant to be a private implementation detail of the consumer.
Lokinet and libsession-util are each manually dealing with adding a signature value; this makes it easier by moving the logic for what/how to sign into bt_producer.
This is the counterpart to bt_*_producer's `append_signature` that aids in verifying the correct signing value as added by append_signature.
tewinget
reviewed
Oct 20, 2023
tewinget
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds helpers to make it easier to add a signature over previous values in a list/dict.
append_signaturetakes a callback that works out the value to be signed then calls a callback to make the signature and appends that as a string.land the previous valuesdand the previous string/value pairsconsume_signature(andrequire_signature) do the opposite: the parse the current value as a string, work out what the signed portion of the parsed string should be, then calls the callback to verify them.next_signaturereturns a 3-tuple (key, msg, sig).This is already being done (manually) in libsession-util; lokinet will also make use of this.