Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for vector sender; path methods #130

Merged
merged 1 commit into from
May 27, 2024
Merged

Bugfix for vector sender; path methods #130

merged 1 commit into from
May 27, 2024

Conversation

dr7ana
Copy link
Collaborator

@dr7ana dr7ana commented May 17, 2024

  • When passing an r-value reference to ::send_datagram(...), we must make the shared_ptr keep-alive prior to constructing the string_view pointing into the data
  • Path comparison methods added plus hash for indexing using paths

@dr7ana dr7ana added the bug Something isn't working label May 17, 2024
@dr7ana dr7ana requested review from jagerman and tewinget May 17, 2024 12:45
@dr7ana dr7ana self-assigned this May 17, 2024
@dr7ana dr7ana enabled auto-merge May 17, 2024 13:11
@dr7ana
bugfix for vector sender; path methods
d4d9941 
- When passing an r-value reference to ::send_datagram(...), we must make the shared_ptr keep-alive prior to constructing the string_view pointing into the data
@dr7ana dr7ana merged commit 2996053 into oxen-io:dev May 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tewinget tewinget tewinget left review comments

@jagerman jagerman jagerman approved these changes

Assignees

@dr7ana dr7ana

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dr7ana @jagerman @tewinget