Connection established and closed callbacks #40

tewinget · 2023-09-06T18:39:25Z

builds on #39

include/quic/error.hpp

Connection established is called when the connection has confirmed the TLS handshake; server does this on ngtcp2 handshake "complete" after sending the final packet for the handshake to the client which will then call ngtcp2 handshake "confirmed". Connection closed callback is called when a connection closes for any reason, including that it timed out and was never actually established (thus acting as a "connection attempt failed" signal as well). In order to have a connection timeout call connection closed, a handshake timeout needed to be set in ngtcp2 (the default was funtionally infinite). 5s should be sufficient, but this can be made configurable at a later time. Tests which were confirming connection establishment or failure have been updated to use the new callbacks.

- no structs for open/close callbacks - added `error.hpp` - reworked bool_waiter in unit tests - little bit of template magic from jason

- Sometimes when ngtcp2 does not want a connection close packet written, we delete the connection from the endpoint's internal map - In these cases, we still want to notify the calling endpoint that the connection was closed

tests/009-close.cpp

src/connection.cpp

src/endpoint.cpp

For whatever reason, sometimes ngtcp2 gives a time point in the past when asked when to wake it up; this was resulting in us never waking it. Normally this is fine, as an incoming packet wakes it and we do't notice, but if no packets come in, new connections we make can fail to timeout correctly. This works around that issue by doing a 0µs timeout if the timeout would be negative.

we need to keep 'closing' connections around for a bit so we can drop any straggler packets. also, if we 'drop connection' here we get multiple calls to the connection closed callback, which is not ideal

also use ngtcp2_ccerr_set_application_error rather then ...set_liberr if the close is an application requested close rather than protocol error or similar supply connection close error code to user-defined connection closed cb adds connection close callback test

src/endpoint.cpp

tewinget force-pushed the conn-state-callbacks branch from 71cc4a1 to 26d1fd7 Compare September 6, 2023 18:41

dr7ana force-pushed the conn-state-callbacks branch from 4b3fef1 to 3ea90d3 Compare September 11, 2023 21:45

tewinget force-pushed the conn-state-callbacks branch 3 times, most recently from 3d9c072 to 38e0075 Compare September 12, 2023 20:59

jagerman reviewed Sep 13, 2023

View reviewed changes

include/quic/error.hpp Show resolved Hide resolved

tewinget and others added 3 commits September 14, 2023 14:09

Connection open/close callback reworking

1157557

- no structs for open/close callbacks - added `error.hpp` - reworked bool_waiter in unit tests - little bit of template magic from jason

Added Endpoint::drop_connection

aa56355

- Sometimes when ngtcp2 does not want a connection close packet written, we delete the connection from the endpoint's internal map - In these cases, we still want to notify the calling endpoint that the connection was closed

tewinget force-pushed the conn-state-callbacks branch 2 times, most recently from e7d4074 to 5e618a4 Compare September 18, 2023 17:45

dr7ana reviewed Sep 18, 2023

View reviewed changes

tests/009-close.cpp Show resolved Hide resolved

dr7ana approved these changes Sep 18, 2023

View reviewed changes