Commits on Sep 22, 2023

1. Fix promise sync in bool_waiter; rename to callback_waiter …

   We were setting the promise in bool_waiter *before* we call the wrapped
   lambda, but that introduces a race condition because we have test code
   that waits on the promise and then checks a value that it expects to
   have been set inside the lambda.
   
   This reverses it so that the promise is set *after* the lambda is
   called, which should solve the intermittent failure of the 009 test
   caused by exactly this race condition.
   
   While here, I also refactored this to a `promise<void>` since we are
   never actually meaningfully using the `bool` value (which either returns
   true, or hangs), and then since it isn't a "bool" waiter anymore,
   renamed to callback_waiter.
   
   `get` doesn't seem useful (it basically is a return-or-hang), so I removed it.
   
   `wait_ready()` felt too long, so I shortened it to `wait()`.
   
   Also adds documentation of the usage of `bool_waiter`.

   

   jagerman committed Sep 22, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 6bf3109
   • Browse repository at this point

   Copy the full SHA

   6bf3109 View commit details

   Browse the repository at this point in the history