Always relay messages in batches #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeaudanBrown
approved these changes
Oct 6, 2019
httpserver/service_node.cpp
Outdated
| void ServiceNode::relay_buffered_messages() { | ||
|
|
||
| // Should we wait for the response first? | ||
| constexpr std::chrono::milliseconds RELAY_INTERVAL = 500ms; |
There was a problem hiding this comment.
2 differently scoped definitions of RELAY_INTERVAL for 200ms and 500ms
Should we just define in larger scope once or just make these the same? Or is the 500ms deliberate because it includes the actual relaying?
There was a problem hiding this comment.
Not deliberate, let's use 350ms for both as the average :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to minimise the number of connections to other SS, so instead of relaying messages individually, we accumulate them in a buffer, processing it periodically (every 200ms).