Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session Android displays the unblinded Id of itself as the original sender when one's own message is quoted, should display "You" instead #1076

Open
1 task done
ghost opened this issue Jan 13, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jan 13, 2023

Code of conduct

Describe the bug

This is an attempt to reproduce/preclude a theoretical equivalent of oxen-io/session-ios#768 for Android, however, I failed to reproduce the same bug but found a different one instead.

Update: eventually a sibling of oxen-io/session-ios#768 is reported here #1088

When someone quotes your message, you should see "You" being quoted, instead of seeing your own unblinded Id being quoted. (update: fixed an inaccurate description)

To reproduce

  1. Create two fresh new accounts on Android called Alice Android and Bob Android
  2. Initially, Alice and Bob are not friends
  3. Both Alice and Bob join a community (with blinded ID enabled?), for example, the official Session Community.
  4. Alice sends a message "This is Alice from Android, testing session bug"
  5. Bob quotes and replies to Alice's message, "Hi Alice, this is Bob from Android, I'm quoting your message"

Expected result:
For the quoted message, Alice should see a You as the original message sender

Actual result:
Alice sees her own unblinded ID 056e...f267 as the original message sender

Screenshots or logs

Screen Shot 2023-01-13 at 8 50 13 pm

Smartphone (please complete the following information):

  • Device: [Pixel 6 Android Emulator]
  • OS: [Android 13]
  • Version of Session or latest commit hash: Session 1.16.3

Additional context

After Bob initialized a friend request to Alice and was accepted, Alice start to see a You as the original sender in her quoted message, but Bob still sees his own unblinded Id in his quoted message, which is weird.

@ghost ghost added the bug Something isn't working label Jan 13, 2023
@ghost
Copy link
Author

ghost commented Jan 13, 2023

As the below screenshot shows, after accepting Bob's friend request, Alice starts to see You when her own message is quoted by Bob. But when Bob's message is quoted by Alice, Bob still sees his own unblinded Id 05f3...171b as the original sender.

Screen Shot 2023-01-13 at 9 26 18 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

0 participants