Merge pull request #3066 from yougotwill/fix/no-ref/group_notifications

fix: legacy groups are unapproved so should allow all notifications
oxen-io · Apr 5, 2024 · 9505407 · 9505407
2 parents 563e4cc + a139299
commit 9505407
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/ts/models/conversation.ts b/ts/models/conversation.ts
@@ -1739,9 +1739,11 @@ export class ConversationModel extends Backbone.Model<ConversationAttributes> {
       return;
     }
     const conversationId = this.id;
+    const isLegacyGroup = this.isClosedGroup() && this.id.startsWith('05');
 
     let friendRequestText;
-    if (!this.isApproved()) {
+    // NOTE: legacy groups are never approved, so we should not cancel notifications
+    if (!this.isApproved() && !isLegacyGroup) {
       window?.log?.info('notification cancelled for unapproved convo', this.idForLogging());
       const hadNoRequestsPrior =
         getConversationController()