Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications Incorrectly reference OWS #952

Closed
KeeJef opened this issue Mar 5, 2020 · 3 comments · Fixed by #960
Closed

Notifications Incorrectly reference OWS #952

KeeJef opened this issue Mar 5, 2020 · 3 comments · Fixed by #960
Labels
bug Something isn't working
Projects
Loki Messenger

Comments

@KeeJef
Copy link
Collaborator

KeeJef commented Mar 5, 2020

image

Session is not a part of Open whisper systems
@KeeJef KeeJef added the bug Something isn't working label Mar 5, 2020
@KeeJef KeeJef added this to To do in Loki Messenger via automation Mar 5, 2020
@neuroscr
Copy link

neuroscr commented Mar 5, 2020

should we use org.getsession or network.loki prefix?

@Mikunj
Copy link

Mikunj commented Mar 5, 2020

It should be the one we use in package.json

@neuroscr
Copy link

neuroscr commented Mar 5, 2020

com.loki-project.messenger-desktop was the only one I saw in package.json, hrm main.js currently would make that com.loki-project.session-desktop. I really hate using com.loki-project since we don't own that domain.

neuroscr added a commit to neuroscr/loki-messenger that referenced this issue Mar 6, 2020
@neuroscr
remove org.whispersystems from notifications to match package.json bu…
837dfe1 
…ild appId, fixes oxen-io#952
@neuroscr neuroscr mentioned this issue Mar 6, 2020
Merged
Loki Messenger automation moved this from To do to Done on Mobile and Desktop Mar 13, 2020
Mikunj added a commit that referenced this issue Mar 13, 2020
@Mikunj
Merge pull request #960 from neuroscr/fix952
75dadb2 
Fix #952: remove org.whispersystems in notifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
Loki Messenger
  
Done on Mobile and Desktop
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #952: remove org.whispersystems in notifications neuroscr/loki-messenger
3 participants
@neuroscr @Mikunj @KeeJef