disable link option on secondary device #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilb
force-pushed
the
disable-link-option-on-secondary-device
branch
from
8b3ea55
to
c81fca5
Compare
Mikunj
reviewed
Mar 26, 2020
neuroscr
reviewed
Mar 26, 2020
neuroscr
approved these changes
Mar 26, 2020
There was a problem hiding this comment.
Looks fine. Just needs Mik's comment addressed. I'd suggest some more comments.
For example in SessionSettingsHeader.tsx we just set disableLinkDeviceButon to true and note about how it's detected turned on, maybe good. Just weird to see an option like that hard coded.
|
Nice, we need this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable the settings button allowing to linking a new device when the current device is already a current device